Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli/command/container: add unit tests for container restart and container stop #5482

Merged
merged 2 commits into from
Sep 26, 2024
Merged

cli/command/container: add unit tests for container restart and container stop #5482

merged 2 commits into from
Sep 26, 2024

Conversation

thaJeztah
Copy link
Member

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added this to the 28.0.0 milestone Sep 26, 2024
@thaJeztah thaJeztah self-assigned this Sep 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.03%. Comparing base (bae4b67) to head (ac502b5).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5482      +/-   ##
==========================================
+ Coverage   59.74%   60.03%   +0.29%     
==========================================
  Files         345      345              
  Lines       23432    23432              
==========================================
+ Hits        14000    14068      +68     
+ Misses       8458     8390      -68     
  Partials      974      974

@thaJeztah
Copy link
Member Author

Booh! I guess we need to copy the config.json, or run authentication inside the e2e containers;

#6 [notary-server internal] load metadata for docker.io/library/notary:server-0.6.1
#6 ERROR: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/notary/manifests/sha256:05d1cceee56e406fae0dafbe82ea53a57f3d9c17d209f6c41ba2e495f5b8941b: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit

@thaJeztah thaJeztah requested a review from a team September 26, 2024 17:19
robmry
robmry approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@robmry robmry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member Author

Thx!

@thaJeztah thaJeztah merged commit daabb15 into docker:master Sep 26, 2024
101 checks passed
@thaJeztah thaJeztah deleted the restart_stop_unit_tests branch September 26, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robmry robmry robmry approved these changes

Assignees

@thaJeztah thaJeztah

Labels
area/testing status/2-code-review
Projects
None yet
Milestone
28.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@thaJeztah @codecov-commenter @robmry